-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMake + MSVC build with setuptools. #5280
Conversation
There are |
Usually, Windows users do not have CMake or MSVC installed on their machines. We should document that running |
@hcho3 We have documents for building C++ library. Also I added some notes here: https://xgboost.readthedocs.io/en/latest/build.html#python-package-installation at last PR. Do you think it's enough? |
@trivialfis I have not had a chance to look at #5271 thoroughly. The updated doc looks good to me. I think we should add a note about needing MSVC specifically for Windows Python. |
@hcho3 Got it. I will add some notes. Feel free to provide your feedback on the new setuptools script. |
Actually, never mind. For now we can keep the build doc as it is. I do want to re-organize the build doc later, something like https://rapids.ai/start.html. See #5282 |
That's not a link to rapids build doc? BTW, how do I remove the use of Note: I think there's minor difference around using CMake between 3.13 and later versions with MSVC. I use CMake 3.16 for this PR. |
You should submit a patch to https://github.com/xgboost-ai/xgboost-ai.github.io.
You can select "Source" in the selector and it display a link to build instruction. MXNet (https://mxnet.apache.org/get_started) does a similar thing. The idea is to make the installation doc page less overwhelming, by letting the user filter the doc by the use case they have in mind. |
Interesting. I was not aware of the difference. |
Got it. Thanks for the pointers. |
@hcho3 I read this answer https://stackoverflow.com/questions/28350214/how-to-build-x86-and-or-x64-on-windows-from-command-line-with-cmake I just took the simplest one (<3.13) and it works even I'm running 3.16. Not sure about the implications. |
Follow up fix for #5271 .